MediaWiki-vita:WikiLove.js

Revert of production error fix - please restore

User:Tacsipacsi, while I think your assessment in the edit summary of https://hu.wikipedia.org/w/index.php?title=MediaWiki:WikiLove.js&oldid=prev&diff=23203177 is completely fair,, right now modules created on wiki pages have zero dependencies by default, so undoing my edit has reintroduced this error and this seems to be the only wiki impacted by this change.

I have created phab:T267039 to deal with the root cause, but we should restore the change rather than allow this to continue to throw errors at high volume until that is dealt with. If not loading the code as before at minimum I ask we add a

if(typeof $.wikiLoveOptions !== 'undefined')

guard with a note pointing to the phabricator ticket.

Jon (WMF) ^vita 2020. november 2., 17:16 (CET)

@Jon (WMF): I strongly disagree with such workarounds. The root cause should be resolved, and you should have a way to hide these error messages from Logstash for the time being. No one complained about missing or superfluous barnstars so far, so even if the error rate is high compared to other errors, this code seems to work most of the time.

Also, your edit introduced a whitespace change that is against mw:Manual:Coding conventions/JavaScript and made the code less consistent. Of course, the coding conventions are not mandatory for on-wiki scripts, but making the code less consistent is certainly not a good way to go, and you, as a global interface administrator, shouldn’t touch that piece of code at all. —Tacsipacsi ^vita 2020. november 2., 21:49 (CET)